undefined check on value as treating value:0 as bad request

ScottLogic · Jan 3, 2024 · d3a6391 · d3a6391
1 parent c173f7d
commit d3a6391
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/backend/src/controller/modelController.ts b/backend/src/controller/modelController.ts
@@ -36,7 +36,7 @@ function handleConfigureModel(req: OpenAiConfigureModelRequest, res: Response) {
 	const configId = req.body.configId as MODEL_CONFIG | undefined;
 	const value = req.body.value;
 
-	if (configId && value && value >= 0) {
+	if (configId && value !== undefined) {
 		const lastConfig = req.session.chatModel.configuration;
 		const maxValue = configId === MODEL_CONFIG.TOP_P ? 1 : 2;
 		const updatedConfig = updateConfigProperty(
@@ -51,6 +51,8 @@ function handleConfigureModel(req: OpenAiConfigureModelRequest, res: Response) {
 		} else {
 			res.status(400).send();
 		}
+	} else {
+		res.status(400).send();
 	}
 }