783 details summary buttons hover and redesign #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswilty
requested review from
pmarsh-scottlogic,
AAloshine-scottlogic and
dhinrichs-scottlogic
chriswilty
force-pushed
the
783-details-summary-buttons-hover-and-redesign
branch
from
e1eb6c3 to
dae0fd1
Compare
pmarsh-scottlogic
suggested changes
Mar 20, 2024
chriswilty
force-pushed
the
783-details-summary-buttons-hover-and-redesign
branch
from
7782e96 to
d621e3c
Compare
pmarsh-scottlogic
suggested changes
Mar 21, 2024
Co-authored-by: Peter Marsh <[email protected]>
pmarsh-scottlogic
approved these changes
Mar 25, 2024
chriswilty
added a commit
that referenced
this pull request
Apr 8, 2024
--------- Co-authored-by: dhinrichs-scottlogic <[email protected]> Co-authored-by: Peter Marsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reimplementation of the native expanding
<details>element, to be more accessible and screen-reader friendly.TIP: hide whitespace when reviewing!
There are a few things wrong with the original, including the arrow icons being read out by screen readers, plus the way the control acts as a button but contains its own descriptive header and content, which was making life difficult as we also have a control toggle to turn a defence on/off, which we want always to be visible even when the details are collapsed.
All the glory belongs to @dhinrichs-scottlogic, I just tidied up a few things here and there.
Resolves #783
Screenshots
Checklist
Have you done the following?