Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct flash of wrong level after Getting Started #878

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Correct flash of wrong level after Getting Started #878

merged 1 commit into from
Mar 28, 2024

Conversation

chriswilty
Copy link
Member

@chriswilty chriswilty commented Mar 26, 2024 •
edited
Loading

Description

There is an issue since #866 was merged, where we see a flash of wrong level when switching between Sandbox and Level 1 from the Getting Started dialog. It's a really brief flash but enough to cause some unease. Hopefully this fixes the problem, though I need another, sharper set of eyes on it! 🤓

Closes #862

Notes

  • There is a useEffect that brings up the MissionInfo dialog whenever the level changes. This was being triggered after update as expected, but additionally we were opening the dialog manually, which was happening in the first update cycle before the level change took effect.

Checklist

Have you done the following?

  • Linked the relevant Issue
  • Added tests
  • Ensured the workflow steps are passing

@chriswilty chriswilty self-assigned this Mar 26, 2024
@chriswilty chriswilty linked an issue Mar 26, 2024 that may be closed by this pull request
Occasionally the modal dialogs can no longer be opened #862
Closed
pmarsh-scottlogic
pmarsh-scottlogic approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@pmarsh-scottlogic pmarsh-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@chriswilty chriswilty force-pushed the 867-one-container-to-rule-them-all branch from 14729b4 to f4d8243 Compare March 28, 2024 08:57
@chriswilty chriswilty force-pushed the 862-flash-of-wrong-level branch from c9fcd7c to 290332d Compare March 28, 2024 08:59
@chriswilty chriswilty force-pushed the 867-one-container-to-rule-them-all branch from f4d8243 to 512ef06 Compare March 28, 2024 10:58
@chriswilty chriswilty force-pushed the 862-flash-of-wrong-level branch from 290332d to 289d450 Compare March 28, 2024 10:59
Base automatically changed from 867-one-container-to-rule-them-all to dev March 28, 2024 11:00
@chriswilty chriswilty force-pushed the 862-flash-of-wrong-level branch from 289d450 to 8b9f36a Compare March 28, 2024 11:03
@chriswilty chriswilty merged commit 2fe8da3 into dev Mar 28, 2024
2 checks passed
@chriswilty chriswilty deleted the 862-flash-of-wrong-level branch March 28, 2024 11:05
chriswilty added a commit that referenced this pull request Apr 8, 2024
@chriswilty
Correct flash of wrong level after Getting Started (#878)
77a7c44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarsh-scottlogic pmarsh-scottlogic pmarsh-scottlogic approved these changes

@kclark-scottlogic kclark-scottlogic Awaiting requested review from kclark-scottlogic

@dhinrichs-scottlogic dhinrichs-scottlogic Awaiting requested review from dhinrichs-scottlogic

Assignees

@chriswilty chriswilty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Occasionally the modal dialogs can no longer be opened
2 participants
@chriswilty @pmarsh-scottlogic