Pch07/ffmpeg non io tests #261
Merged
+3,409
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipch07
force-pushed
the
pch07/ffmpeg_non_io_tests
branch
from
d716411 to
edc6a64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 63.92% 72.75% +8.83%
==========================================
Files 203 203
Lines 15846 15792 -54
==========================================
+ Hits 10129 11489 +1360
+ Misses 5717 4303 -1414
... and 1 file with indirect coverage changes
|
TroyKomodo
reviewed
Jan 23, 2025
philipch07
force-pushed
the
pch07/ffmpeg_non_io_tests
branch
from
5af54c9 to
68cf0da
Compare
TroyKomodo
reviewed
Jan 25, 2025
TroyKomodo
reviewed
Jan 25, 2025
… frame + set audio ch_layout)
TroyKomodo
reviewed
Jan 28, 2025
|
?brawl merge |
|
📌 Commit 34c6271 has been approved and added to the merge queue. Requested by: @TroyKomodo Approved by: |
|
?brawl cancel |
scuffle-brawl bot
added a commit
that referenced
this pull request
Jan 28, 2025
Pch07/ffmpeg non io tests Added tests to the non io files in the ffmpeg crate. So far I have only run into one issue: In the `logs.rs` file, I updated some log levels to their respective names in `log_callback_tracing()`, let me know if this change is appropriate. Additionally, `test_log_callback_tracing()` excludes the `tracing::warn!` case because it doesn't work for some reason; I couldn't figure this out. In the `frame.rs` file, the last test is incorrect due to `is_audio()` returning `false` instead of `true`. I left it commented for now. In the `encoder.rs` file, I didn't include tests for the `Encoder::send_frame()`, `Encoder::receive_packet()`, `MuxerEncoder::send_eof()`, `MuxerEncoder::send_frame()`, or `MuxerEncoder::handle_packets()` functions. In the `decoder.rs` file, I didn't include tests for `GenericDecoder::send_packet()`, `GenericDecoder::send_eof()`, or `GenericDecoder::receive_frame()` functions. The untested functions are due to them being kinda complex (also they seem to be related to the untested functions in the ffmpeg/io folder. It would probably be better to work on all of those in one go since it seems pretty technical. Requested-by: TroyKomodo <49777269+TroyKomodo@users.noreply.github.com>
scuffle-brawl
bot
added
B-brawl-merging
and removed
B-brawl-queued
B-brawl-merging
labels
TroyKomodo
approved these changes
Jan 28, 2025
|
🚨 Cancelled CI run |
|
?brawl merge |
|
📌 Commit 34c6271 has been approved and added to the merge queue. Requested by: @TroyKomodo Approved by: @TroyKomodo |
|
🎉 Build successful! Approved by: @TroyKomodo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to the non io files in the ffmpeg crate.
So far I have only run into one issue:
In the
logs.rsfile, I updated some log levels to their respective names inlog_callback_tracing(), let me know if this change is appropriate. Additionally,test_log_callback_tracing()excludes thetracing::warn!case because it doesn't work for some reason; I couldn't figure this out.In the
frame.rsfile, the last test is incorrect due tois_audio()returningfalseinstead oftrue. I left it commented for now.In the
encoder.rsfile, I didn't include tests for theEncoder::send_frame(),Encoder::receive_packet(),MuxerEncoder::send_eof(),MuxerEncoder::send_frame(), orMuxerEncoder::handle_packets()functions.In the
decoder.rsfile, I didn't include tests forGenericDecoder::send_packet(),GenericDecoder::send_eof(), orGenericDecoder::receive_frame()functions.The untested functions are due to them being kinda complex (also they seem to be related to the untested functions in the ffmpeg/io folder. It would probably be better to work on all of those in one go since it seems pretty technical.