rtmp cleanup

[TroyKomodo]

some work towards cleaning up the rtmp implementation

CLOUD-32

[cloudflare-workers-and-pages]

Deploying scuffle-docrs with    Cloudflare Pages

Latest commit:	3d74276
Status:	✅  Deploy successful!
Preview URL:	https://7db57f30.scuffle-docrs.pages.dev
Branch Preview URL:	https://pr-268.scuffle-docrs.pages.dev

View logs

[codecov]

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (d7ade37) to head (3d74276).
Report is 77 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
crates/rtmp/src/handshake/server.rs	91.66%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   79.76%   79.04%   -0.73%     
==========================================
  Files         210      193      -17     
  Lines       15204    14619     -585     
==========================================
- Hits        12128    11555     -573     
+ Misses       3076     3064      -12     

Files with missing lines	Coverage Δ
crates/rtmp/src/chunk/decoder.rs	93.19% <100.00%> (ø)
crates/rtmp/src/chunk/define.rs	96.29% <ø> (ø)
crates/rtmp/src/chunk/encoder.rs	100.00% <ø> (ø)
crates/rtmp/src/handshake/define.rs	0.00% <ø> (ø)
crates/rtmp/src/handshake/digest.rs	96.42% <ø> (ø)
crates/rtmp/src/messages/define.rs	100.00% <ø> (ø)
crates/rtmp/src/messages/parser.rs	100.00% <100.00%> (ø)
crates/rtmp/src/netconnection/writer.rs	100.00% <ø> (ø)
crates/rtmp/src/netstream/writer.rs	100.00% <ø> (ø)
...rates/rtmp/src/protocol_control_messages/reader.rs	100.00% <ø> (ø)
... and 5 more

... and 10 files with indirect coverage changes

Components	Coverage Δ
scuffle-aac	89.65% <ø> (ø)
scuffle-amf0	100.00% <ø> (ø)
scuffle-av1	98.66% <ø> (ø)
scuffle-batching	100.00% <ø> (ø)
scuffle-bootstrap	86.66% <ø> (ø)
scuffle-bytes-util	100.00% <ø> (ø)
scuffle-context	100.00% <ø> (ø)
scuffle-expgolomb	100.00% <ø> (ø)
scuffle-ffmpeg	91.13% <ø> (-0.12%)	⬇️
scuffle-flv	96.11% <ø> (ø)
scuffle-future-ext	50.00% <ø> (ø)
scuffle-h3-webtransport	0.00% <ø> (ø)
nutype-enum	71.87% <ø> (ø)
scuffle-http	86.65% <ø> (ø)
scuffle-metrics	66.39% <ø> (ø)
postcompile	79.45% <ø> (-0.55%)	⬇️
scuffle-pprof	100.00% <ø> (ø)
scuffle-rtmp	95.63% <94.82%> (-0.66%)	⬇️
scuffle-settings	93.66% <ø> (ø)
scuffle-signal	100.00% <ø> (ø)

[TroyKomodo]

?brawl try

[scuffle-brawl]

🔒 Merge conflict
This pull request and the main branch have diverged in a way
that cannot be automatically merged. Please rebase your branch ontop of the
latest main branch and let the reviewer approve again.

Attempted merge from 69aad99 into 5f136ca

How do I rebase?

1. git checkout troy/rtmp (Switch to your branch)
2. git fetch upstream main (Fetch the latest changes from the
   upstream)
3. git rebase upstream/main -p (Rebase your branch onto the
   upstream branch)
4. Follow the prompts to resolve any conflicts (use git status if you get
   lost).
5. git push self troy/rtmp --force-with-lease (Update this PR)`

You may also read
Git Rebasing to Resolve Conflicts by Drew Blessing
for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub.
It uses git merge instead of git rebase which makes the PR commit
history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually
due to difference between how Cargo.lock conflict is handled during merge
and rebase. This is normal, and you should still perform step 5 to update
this PR.

[TroyKomodo]

?brawl try

[scuffle-brawl]

⌛ Trying commit 3e3b195 with merge 864d28f...

[scuffle-brawl]

💔 Test failed - brawl-done

[TroyKomodo]

?brawl try

[scuffle-brawl]

⌛ Trying commit 5020027 with merge e9bd647...

[scuffle-brawl]

💔 Test failed - brawl-done

[TroyKomodo]

?brawl try

[scuffle-brawl]

⌛ Trying commit d390b17 with merge a43c36d...

[scuffle-brawl]

💔 Test failed - brawl-done

[lennartkloock]

Superseded by #396