Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support partial index #478

Merged
merged 8 commits into from
Sep 28, 2024
Merged

support partial index #478

merged 8 commits into from
Sep 28, 2024

Conversation

kyoto7250
Copy link
Contributor

@kyoto7250 kyoto7250 commented Oct 16, 2022 •
edited
Loading

PR Info

close #396
We supports partial index by this PR.

Adds

  • support partial index.
    • resolve conflict
    • check comment

Related

#405 (original PR)

@kyoto7250 kyoto7250 mentioned this pull request Oct 16, 2022
Closed
1 task
ikrivosheev
ikrivosheev approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyoto7250 thank you! LGTM!

@ikrivosheev
Copy link
Member

@kyoto7250 is this PR ready?)

@kyoto7250
Copy link
Contributor Author

kyoto7250 commented Oct 18, 2022 •
edited
Loading

@ikrivosheev Thank you for your quick reply :)

I want to confirm that this PR works as expected in the database at hand (not yet confirmed, so this PR is a WIP).

@ikrivosheev
Copy link
Member

@kyoto7250 any updates?)

billy1624
billy1624 reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kyoto7250, I highly recommend this site for testing SQL syntax across various databases :)

https://dbfiddle.uk/

@ikrivosheev
Copy link
Member

Hey @kyoto7250, I highly recommend this site for testing SQL syntax across various databases :)

@billy1624 which site do you mean?

@billy1624
Copy link
Member

@ikrivosheev Good question!! I forgot to post the link loll

@ikrivosheev
Copy link
Member

@kyoto7250 hello, any updates?)

@wolfv
Copy link
Contributor

wolfv commented Apr 4, 2023

We would love to see this feature land, too! :)

@kyoto7250
Copy link
Contributor Author

kyoto7250 commented Oct 10, 2023 •
edited
Loading

Ah...sorry, I completely forgot about this PR...
It seemed like the notifications were turned off in my account. Is this still an alive PR?

I need to catch up on this library updates, so if you hurried up, you can close this pr.

@tyt2y3
Copy link
Member

tyt2y3 commented Oct 12, 2023

Glad that you are back! Apart from the conflicts, I think we can still merge this PR.

@IgnisDa
Copy link
Contributor

IgnisDa commented Oct 27, 2023 •
edited
Loading

Hey @kyoto7250 @tyt2y3 any updates on this? I could really use this feature.

@IgnisDa IgnisDa mentioned this pull request Oct 27, 2023
Closed
@kyoto7250 kyoto7250 mentioned this pull request Nov 2, 2023
Closed
@kyoto7250
Copy link
Contributor Author

I made the PR for fixing failed CI.

#718

@IgnisDa
Copy link
Contributor

IgnisDa commented Jun 19, 2024

@kyoto7250 I believe this should be ready to be merged?

@kyoto7250
Copy link
Contributor Author

kyoto7250 commented Jun 19, 2024 •
edited
Loading

Okay, I will check in this week.
Thank you for calling me.

@kyoto7250 kyoto7250 marked this pull request as ready for review June 24, 2024 13:34
@kyoto7250 kyoto7250 requested a review from billy1624 June 24, 2024 13:34
@kyoto7250
Copy link
Contributor Author

After rebasing, I increased the version of bigdecimals so that the build would succeed.

@kyoto7250
Copy link
Contributor Author

This PR is now available for review.

@kyoto7250
Copy link
Contributor Author

@billy1624 @ikrivosheev
Sorry for the long delay in correcting the PR.
Could you give me your review?

@tyt2y3 tyt2y3 merged commit ee234f1 into SeaQL:master Sep 28, 2024
29 checks passed
@onichandame
Copy link

nice job! I've been waiting too long for this to land 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

🎉 Released In 0.32.0-rc.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@github-actions GitHub Actions
Copy link

🎉 Released In 0.32.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev approved these changes

@tyt2y3 tyt2y3 tyt2y3 approved these changes

@billy1624 billy1624 Awaiting requested review from billy1624

Assignees

@kyoto7250 kyoto7250

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for partial index
7 participants
@kyoto7250 @ikrivosheev @billy1624 @wolfv @tyt2y3 @IgnisDa @onichandame