Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement postgres vector extension #137

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

28Smiles
Copy link

@28Smiles 28Smiles commented Sep 1, 2024

PR Info

Once this gets merged i'll clean the implementations of the feature in sea-orm. I tested the feature with my forks.

New Features

  • Support for the postgres vector extension

Breaking Changes

None, all feature flagged

Changes

  • Add postgres-vector feature flag
  • Add pgvector for schema discorvery

28Smiles and others added 6 commits August 8, 2024 11:01
(cherry picked from commit 0806dba)
(cherry picked from commit 6d101f1)
(cherry picked from commit 99513fb)
@28Smiles
Copy link
Author

@tyt2y3 Status?

@28Smiles
Copy link
Author

@tyt2y3 Is there anything I can do to get this merged?

@tyt2y3
Copy link
Member

tyt2y3 commented Sep 28, 2024

Thank you! but sorry I don't think we should piggy back on Type::Unknown. Actually I think we can add a new variant to postgres/def/types.rs and use it!

Note: https://github.com/SeaQL/sea-schema/blob/master/src/postgres/def/types.rs#L146, https://github.com/SeaQL/sea-schema/blob/master/src/postgres/def/types.rs#L211

@28Smiles
Copy link
Author

28Smiles commented Sep 28, 2024

I will look into it and make the changes, thank you

@28Smiles
Copy link
Author

Should be fine now

@28Smiles 28Smiles mentioned this pull request Nov 27, 2024
2 tasks
@Daniel-A-Gutierrez
Copy link

@billy1624 Hello, seems like this might be in need of a bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants