feat(mysql): add support for vector indices #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlanetScale recently added vector support to their fork of mysql. If a vector index is added to it, then sea-orm generate entity command panics because the index type is not recognized by its parser. This PR adds support for recognizing vector indices as a valid index type. Test Plan: Created a planet scale database with a vector index, and ran `generate entity` command. Verified that after this change, the command no longer crashes and creates valid files.
|
sorry, I don't yet have a guideline on how to handle third-party database vendors with proprietary extensions |
|
may be at least we put on an additional feature guard |
ammubhave
force-pushed
the
mysqlvector
branch
from
b91c2bb
to
db79528
Compare
ammubhave
force-pushed
the
mysqlvector
branch
from
db79528
to
039a1de
Compare
|
Gated behind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlanetScale recently added vector support to their fork of mysql. If a vector index is added to it, then sea-orm generate entity command panics because the index type is not recognized by its parser.
https://planetscale.com/docs/concepts/vectors#vector-index-parameters
This PR adds support for recognizing vector indices as a valid index type.
Test Plan: Created a planet scale database with a vector index, and ran
generate entitycommand. Verified that after this change, the command no longer crashes and creates valid files.PR Info
New Features
VECTORindex supportBug Fixes
Breaking Changes
Changes