Skip to content

Commit

Permalink
add runtime dependency on libcuvs in cuvs wheels (rapidsai#615)
Browse files Browse the repository at this point in the history
`cuvs-cu{11,12}` wheels don't currently have a runtime dependency on `libcuvs-cu{11,12}`. They need one, for library-loading:

https://github.com/rapidsai/cuvs/blob/e9983e17408e6bec6f2558f9df49be97a7255417/python/cuvs/cuvs/__init__.py#L19-L25

This was missed in rapidsai#594. This PR adds it.

## Notes for Reviewers

Adding for searchability... this bug can result in issues like this at runtime when using `cuvs` installed from wheels:

> ImportError: libcuvs_c.so: cannot open shared object file: No such file or directory

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#615
  • Loading branch information
jameslamb authored and Vivek Narang committed Jan 27, 2025
1 parent b84ec10 commit 7709221
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ files:
extras:
table: project
includes:
- depends_on_libcuvs
- depends_on_pylibraft
- run_py_cuvs
py_test_cuvs:
Expand Down
1 change: 1 addition & 0 deletions python/cuvs/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ license = { text = "Apache 2.0" }
requires-python = ">=3.10"
dependencies = [
"cuda-python",
"libcuvs==25.2.*,>=0.0.0a0",
"numpy>=1.23,<3.0a0",
"pylibraft==25.2.*,>=0.0.0a0",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
Expand Down

0 comments on commit 7709221

Please sign in to comment.