Two more Slime rules ported

SeasideSt · Jan 7, 2024 · e34bcc2 · e34bcc2
1 parent 18a37b0
commit e34bcc2
Show file tree

Hide file tree

Showing 16 changed files with 69 additions and 7 deletions.
diff --git a/.../Grease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/README.md b/.../Grease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/README.md
diff --git a/...ry/Grease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/instance/group.st b/...ry/Grease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/instance/group.st
@@ -0,0 +1,4 @@
+accessing
+group
+
+	^ 'Grease Portability'
diff --git a/...ease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/instance/initialize.st b/...ease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/instance/initialize.st
@@ -0,0 +1,7 @@
+initialization
+initialize
+
+	super initialize.
+	self matchesAny: #( 
+		'`@receiver canPerform: `@selector'
+		'`@receiver canUnderstand: `@selector' )
diff --git a/...ory/Grease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/instance/name.st b/...ory/Grease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/instance/name.st
@@ -0,0 +1,4 @@
+accessing
+name
+
+	^ 'Sends #canPerform: or #canUnderstand:'
diff --git a/...rease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/instance/rationale.st b/...rease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/instance/rationale.st
@@ -0,0 +1,4 @@
+accessing
+rationale
+
+	^ '#canPerform: or #canUnderstand: are not portable.'
diff --git a/...tory/Grease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/properties.json b/...tory/Grease-Pharo110-Slime.package/GRUsesCanPerformOrUnderstandRule.class/properties.json
@@ -0,0 +1,11 @@
+{
+	"commentStamp" : "",
+	"super" : "GRReSlimeParseTreeLintRule",
+	"category" : "Grease-Pharo110-Slime",
+	"classinstvars" : [ ],
+	"pools" : [ ],
+	"classvars" : [ ],
+	"instvars" : [ ],
+	"name" : "GRUsesCanPerformOrUnderstandRule",
+	"type" : "normal"
+}
diff --git a/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/README.md b/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/README.md
diff --git a/...ease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/afterCheck.mappings..st b/...ease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/afterCheck.mappings..st
@@ -0,0 +1,4 @@
+hooks
+afterCheck: aNode mappings: mappingDict
+
+	^ aNode methodNode selector = #hash
diff --git a/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/group.st b/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/group.st
@@ -0,0 +1,4 @@
+accessing
+group
+
+	^ 'Grease Portability'
diff --git a/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/initialize.st b/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/initialize.st
@@ -0,0 +1,5 @@
+initialization
+initialize
+
+	super initialize.
+	self matches: '`@receiver class hash'
diff --git a/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/name.st b/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/name.st
@@ -0,0 +1,4 @@
+accessing
+name
+
+	^ 'Uses its class for hash'
diff --git a/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/rationale.st b/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/instance/rationale.st
@@ -0,0 +1,4 @@
+accessing
+rationale
+
+	^ 'The hash of an object should not depend on the hash of its class as some Smalltalk have non-constant class hashes.'
diff --git a/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/properties.json b/repository/Grease-Pharo110-Slime.package/GRUsesClassForHashRule.class/properties.json
@@ -0,0 +1,11 @@
+{
+	"commentStamp" : "",
+	"super" : "GRReSlimeParseTreeLintRule",
+	"category" : "Grease-Pharo110-Slime",
+	"classinstvars" : [ ],
+	"pools" : [ ],
+	"classvars" : [ ],
+	"instvars" : [ ],
+	"name" : "GRUsesClassForHashRule",
+	"type" : "normal"
+}
diff --git a/...tory/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testEmptyStatements.st b/...tory/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testEmptyStatements.st
@@ -12,4 +12,4 @@ testEmptyStatements
 	self 
 		assertRule: ReMultiplePeriodsTerminatingStatementRule
 		matches: { class>>#emptyStatement1 . class>>#emptyStatement2 . class>>#emptyStatement3 . class>>#emptyStatement4 }
-		ignoring: (Array with: GRUnnecessaryLastPeriodRule)
+		ignoring: (Array with: ReUnnecessaryLastPeriodRule)
diff --git a/...-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testUsesCanPerformOrUnderstand.st b/...-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testUsesCanPerformOrUnderstand.st
@@ -1,6 +1,6 @@
 tests-parsetree
 testUsesCanPerformOrUnderstand
-	<expectedFailure>
+
 	| class |
 	class := self defineSubClassOf: #GRObject.
 	self
@@ -16,5 +16,5 @@ testUsesCanPerformOrUnderstand
 			Object respondsTo: #new'
 		in: class.
 	self 
-		runRule: GRUsesCanPerformOrUnderstandRule
-		selectors: #(invalid1 invalid2)
+		assertRule: GRUsesCanPerformOrUnderstandRule
+		matches: { class>>#invalid1 . class>>#invalid2 }
diff --git a/...ory/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testUsesClassForHash.st b/...ory/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/testUsesClassForHash.st
@@ -1,6 +1,6 @@
 tests-parsetree
 testUsesClassForHash
-	<expectedFailure>
+
 	| class |
 	class := self defineSubClassOf: #GRObject.
 	self
@@ -12,5 +12,5 @@ testUsesClassForHash
 			^ super hash bitXor: self class hash'
 		in: class.
 	self 
-		runRule: GRUsesClassForHashRule
-		selectors: #(hash)
+		assertRule: GRUsesClassForHashRule
+		matches: { class>>#hash }