-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File utilities for streaming uploads #138
File utilities for streaming uploads #138
Conversation
…latform and concrete implementations to GRPharoPlatform and GRSqueakPlatform
The one failure is due to an unexpected pass. This should be fixed in a separate PR. |
This PR also deals with the issue discussed in #1159. This might not be the best solution. |
Hi @theseion ! I wonder if it would not be easier (and keep the codebase more succint) to write |
#writeFileStreamOn:do:binary: already provides this functionality
#writeFileStreamOn:do:binary: already provides this functionality
#writeFileStreamOn:do:binary: already provides this functionality
#writeFileStreamOn:do:binary: already provides this functionality
You're right, the new method is unnecessary. I've removed it. |
@theseion the unexpected pass is indeed because svenvc/zinc#86 is now fixed in Pharo10. I now removed it in ce61d53 |
I would say we need a test for the new method. |
Thanks, much appreciated! |
This PR accompanies SeasideSt/Seaside#1196.