Re-add removed logging line, add state file to gitignore #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AetherUnbound
requested review from
ccaarryy,
fernando-mc,
evamaxfield,
JustinRoll,
mitchellharper12,
mpuckett159 and
tastyDanish
mpuckett159
reviewed
Oct 13, 2020
| @@ -130,3 +130,6 @@ dmypy.json | |||
|
|
|||
| # IDE | |||
| .idea/ | |||
|
|
|||
| # Auto scanner file | |||
| .autoscanner-state-file | |||
There was a problem hiding this comment.
I thought about this but thought maybe since it was user configurable we wouldn't do it, but this makes sense since it's a pretty advanced config parameter.
There was a problem hiding this comment.
Totally, for the default I think it makes sense to add. If they're going to pick a different path, it'd likely be out of the repo scope anyway I think.
mpuckett159
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-adds a logging line that was removed in #36, and also adds the default auto scanner state file to the gitignore.