-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for CI: Travis-CI and AppVeyor #112
Conversation
@@ -0,0 +1,61 @@ | |||
# <~> Travis integration file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't prefix comments with decorative elements. (The fact that this is your contribution is tracked by Git just fine.)
Seems to be working as intended now - 3 Python versions on Linux (2.5, 2.6, 2.7), 2 on OS X (2.6, 2.7), and 2 on Windows 2012 Server RC2 (2.6, 2.7), with the Windows builds running on 32- and 64-bit architecture. |
# Travis integration file. | ||
# Seattle supports Python 2.5 through 2.7, per | ||
# seattle.poly.edu/wiki/ProgrammersPage | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProgrammersPage only mentions Python v2.5/v2.6
Either change on ProgrammersPage or link to https://seattle.poly.edu/wiki/BuildInstructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in https://github.com/SeattleTestbed/docs/blob/master/Contributing/BuildInstructions.md which supersedes the Trac wiki page.
However, we should note that we include Python 2.5 for testing still because it is what PlanetLab runs.
I confirm successful runs using provided appvoyer config on repy_v2 master branch (triggered by pushing appvoyer.yml) and on test branch (triggered via UI - New Build). Tests ran on Windows x86 and x64 (Python v2.7.11, v2.6.6). Here are the results. |
Thanks for the review and comments. We'll address them separately, see SeattleTestbed/continuous-integration#2, and deploy the CI configs from there. I'm closing this PR for the time being. |
To be sure that we won't omit any changes, I locally compared the relevant files: $ diff -u continuous-integration/.travis.yml repy_v2-awwad/.travis.yml
# no output - files don't differ
$ diff -u continuous-integration/appveyor.yml repy_v2-awwad/appveyor.yml
# no output - files don't differ |
The addition of these .travis.yml and appveyor.yml files here configures Travis-CI and AppVeyor to run automated tests for each push to the repository.
An explanation of CI setup and configuration is currently available here.
You can see the build results here: