Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli creation capability #143

Merged
merged 17 commits into from
Nov 24, 2024
Merged

Add cli creation capability #143

merged 17 commits into from
Nov 24, 2024

Conversation

Sebastian-Webster
Copy link
Owner

@Sebastian-Webster Sebastian-Webster commented Nov 16, 2024

This pull request closes #141

TODO before this can be merged

  • Add documentation for running from cli
  • Update issue template for bugs to say whether the issue occurred while running from the cli or from application code
  • Allow database options to be passed to the cli
  • Add database deletion when exiting
  • Add binary deletion when exiting if downloadBinaryOnce is false
  • Add log message when stopping the database
  • Move exit handler to startMySQL from startMySQLProcess
  • Add option type validation #146 gets closed

@Sebastian-Webster Sebastian-Webster added the enhancement New feature or request label Nov 16, 2024
@Sebastian-Webster Sebastian-Webster self-assigned this Nov 16, 2024
@Sebastian-Webster Sebastian-Webster marked this pull request as draft November 16, 2024 02:17
@Sebastian-Webster
Copy link
Owner Author

Sebastian-Webster commented Nov 16, 2024

EDIT - Moved to top comment

@Sebastian-Webster Sebastian-Webster marked this pull request as ready for review November 24, 2024 00:23
@Sebastian-Webster Sebastian-Webster merged commit 52baa9e into main Nov 24, 2024
29 checks passed
@Sebastian-Webster Sebastian-Webster deleted the ephemeral-cli-creation branch November 24, 2024 13:58
@Sebastian-Webster Sebastian-Webster restored the ephemeral-cli-creation branch November 24, 2024 13:58
@Sebastian-Webster Sebastian-Webster deleted the ephemeral-cli-creation branch November 24, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to create database via npx and similar alternatives
1 participant