Change the get function to let user find country by name #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedromcorreia
force-pushed
the
feature/get_country_by_name
branch
from
1e81bf2 to
48f16f5
Compare
ghost
reviewed
May 7, 2021
lib/countries.ex
Outdated
| """ | ||
|
|
||
| def get(country_code) do | ||
| [country] = filter_by(:alpha2, country_code) | ||
| def get(attrs) when bit_size(attrs) == 16 do |
There was a problem hiding this comment.
Could you rename this function to get_by_alpha2
pedromcorreia
force-pushed
the
feature/get_country_by_name
branch
from
ce16b19 to
854863b
Compare
ghost
reviewed
May 8, 2021
|
|
||
| case length(country) do | ||
| 0 -> | ||
| [] |
There was a problem hiding this comment.
The returned value is not consistent and breaking the current API.
We could update it to adopt the following pattern:
{:ok, country}
:not_found pattern
And also add a get! function that breaks if country does not exist.
There was a problem hiding this comment.
Indeed, you can change the whole case in this way:
case country do
[] -> []
[country_info | _] -> country_info
end
| iex> name | ||
| "Poland" | ||
|
|
||
| """ | ||
|
|
||
| def get(country_code) do | ||
| [country] = filter_by(:alpha2, country_code) | ||
| def get_by_alpha2(attrs) when bit_size(attrs) == 16 do |
There was a problem hiding this comment.
because you're using a strong match, you should add a ! indicating that if the country isn't found it's going to fail.
def get_by_alpha2!(<<_ :: binary-size(16)>> = attrs) do
hd(filter_by(:alpha2, attrs))
end
def get_by_alpha2(<<_ :: binary-size(16)>> = attrs) do
case filter_by(:alpha2, attrs) do
[] -> nil
[country] -> country
end
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the function get to use guard, this allows users to find countries by name and returning only one record.