Add ps:scale to Cli, readme #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making this, super clean. Adding a command took only a few minutes because of the solid setup. |
| desc "ps:scale PROC1=SCALE1 [PROC2=SCALE2 ...]", "Scale one or more Procfile processes" | ||
| def ps_scale(*args) | ||
|
|
||
| args = args.map{|arg| |
There was a problem hiding this comment.
Could you make this a block and use map! (Which also gets rid of the assignment) .
args.map! do |arg|
...
end
|
Thanks for your contribution! <3 |
| @@ -10,6 +10,30 @@ def ps | |||
| run_command "ps #{app_name}" | |||
| end | |||
|
|
|||
| desc "ps:scale PROC1=SCALE1 [PROC2=SCALE2 ...]", "Scale one or more Procfile processes" | |||
| def ps_scale(*args) | |||
|
|
|||
There was a problem hiding this comment.
Please 🔥 the new line here.
SebastianSzturo
requested changes
Jan 3, 2017
There was a problem hiding this comment.
Your branch is not working for me locally. Could you make sure that your new command is mapped here.
Could you also please confirm that your changes are working for you locally? You can test it by:
- Uninstalling the current gem version -
gem uninstall dokku-cli - Building the local gem file -
gem build dokku-cli.gemspec - Installing the generated gem -
gem install dokku-cli-*.gem
Thanks! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.