Skip to content

Commit

Permalink
fix: reset zxing-cpp to b152afd
Browse files Browse the repository at this point in the history
`validateITFCheckSum`, `tryCode39ExtendedMode` and `validateCode39CheckSum`
are deprecated in [later commits](https://github.com/zxing-cpp/zxing-cpp/commits/master/?since=2024-01-26).
  • Loading branch information
Sec-ant committed Jan 29, 2024
1 parent 898bf3d commit de36dce
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .changeset/curly-chefs-retire.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"zxing-wasm": patch
---

reset zxing-cpp to b152afd

- `validateITFCheckSum`, `tryCode39ExtendedMode` and `validateCode39CheckSum` are deprecated in [later commits](https://github.com/zxing-cpp/zxing-cpp/commits/master/?since=2024-01-26).
3 changes: 0 additions & 3 deletions src/bindings/readerOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,21 +84,18 @@ export interface ZXingReaderOptions {
* If `true`, the Code-39 reader will try to read extended mode.
*
* @defaultValue `false`
* @deprecated upstream
*/
tryCode39ExtendedMode: boolean;
/**
* Assume Code-39 codes employ a check digit and validate it.
*
* @defaultValue `false`
* @deprecated upstream
*/
validateCode39CheckSum: boolean;
/**
* Assume ITF codes employ a GS1 check digit and validate it.
*
* @defaultValue `false`
* @deprecated upstream
*/
validateITFCheckSum: boolean;
/**
Expand Down

3 comments on commit de36dce

@axxel
Copy link

@axxel axxel commented on de36dce Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why you reverted back to the pre-deprecated version?

Did you note that I did "un-deprecate" one of the 3 myself and also re-enabled the effect of the other two (until the next major release, which will then remove them)?

@Sec-ant
Copy link
Owner Author

@Sec-ant Sec-ant commented on de36dce Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why you reverted back to the pre-deprecated version?

I remembered they were not only deprecated but the behaviors were also changed at that time. I reverted the changes to avoid introducing breaking changes without bumping the major version number.

Did you note that I did "un-deprecate" one of the 3 myself

Yes, you're referring to tryCode39ExtendedMode I guess?

also re-enabled the effect of the other two (until the next major release

I wasn't aware of that. I checked the history again and I assume they were re-enabled in 2f3c72c? In this case I think I can move on to target the latest commit now :)

I'm working on the React hooks recently and I plan to provide the feature before introducing any breaking changes. That's why I prefer the API to be kept stable before the react part is finished.

@axxel
Copy link

@axxel axxel commented on de36dce Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're referring to tryCode39ExtendedMode I guess?

Yes.

also re-enabled the effect of the other two (until the next major release

I wasn't aware of that. I checked the history again and I assume they were re-enabled in 2f3c72c? In this case I think I can move on to target the latest commit now :)

Yes. And add those @deprecated upstream hints back in, so that people stop / never start using those properties ;).

I'm working on the React hooks recently and I plan to provide the feature before introducing any breaking changes. That's why I prefer the API to be kept stable before the react part is finished.

I see.

Also, I encourage you to think about how to introduce the Result -> Barcode name change in your project.

Please sign in to comment.