-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
`validateITFCheckSum`, `tryCode39ExtendedMode` and `validateCode39CheckSum` are deprecated in [later commits](https://github.com/zxing-cpp/zxing-cpp/commits/master/?since=2024-01-26).
- Loading branch information
Showing
3 changed files
with
8 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"zxing-wasm": patch | ||
--- | ||
|
||
reset zxing-cpp to b152afd | ||
|
||
- `validateITFCheckSum`, `tryCode39ExtendedMode` and `validateCode39CheckSum` are deprecated in [later commits](https://github.com/zxing-cpp/zxing-cpp/commits/master/?since=2024-01-26). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule zxing-cpp
updated
16 files
de36dce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why you reverted back to the pre-deprecated version?
Did you note that I did "un-deprecate" one of the 3 myself and also re-enabled the effect of the other two (until the next major release, which will then remove them)?
de36dce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remembered they were not only deprecated but the behaviors were also changed at that time. I reverted the changes to avoid introducing breaking changes without bumping the major version number.
Yes, you're referring to
tryCode39ExtendedMode
I guess?I wasn't aware of that. I checked the history again and I assume they were re-enabled in
2f3c72c
? In this case I think I can move on to target the latest commit now :)I'm working on the
React
hooks recently and I plan to provide the feature before introducing any breaking changes. That's why I prefer the API to be kept stable before the react part is finished.de36dce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Yes. And add those
@deprecated upstream
hints back in, so that people stop / never start using those properties ;).I see.
Also, I encourage you to think about how to introduce the
Result
->Barcode
name change in your project.