Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Member Ignoring Method smell in ShoppingListConverterImpl class #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor Member Ignoring Method smell in ShoppingListConverterImpl class #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions ...oppinglist/logic/shoppingList/business/impl/converter/impl/ShoppingListConverterImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,28 +65,20 @@ public void convertItemToEntity(ListItem item, ShoppingListEntity entity)
entity.setPriority(item.getPriority());
}

private void setReminder(ListItem item, ShoppingListEntity entity)
{
if ( item.getReminderCount() != null )
{
if ( item.isReminderEnabled() )
{
if ( !StringUtils.isEmpty(item.getReminderCount()) )
{
entity.setReminderCount(Integer.valueOf(item.getReminderCount()));
}
else
{
entity.setReminderCount(0);
}
}
else
{
entity.setReminderCount(null);
}
entity.setReminderUnit(Integer.valueOf(item.getReminderUnit()));
}
}
private static void setReminder(ListItem item, ShoppingListEntity entity) {
if (item.getReminderCount() != null) {
if (item.isReminderEnabled()) {
if (!StringUtils.isEmpty(item.getReminderCount())) {
entity.setReminderCount(Integer.valueOf(item.getReminderCount()));
} else {
entity.setReminderCount(0);
}
} else {
entity.setReminderCount(null);
}
entity.setReminderUnit(Integer.valueOf(item.getReminderUnit()));
}
}

@Override
public void convertEntityToItem(ShoppingListEntity entity, ListItem item)
Expand Down