Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation + 2 original strings modifications #77

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

oleole39
Copy link

Hello,

First of all thank you for this great app!

This pull request includes:

  • two strings modifications in the original locale (US)
  • French translation (FR)

I hereby confirm I have read the contributing guidelines by reporting the word "Privacy".

@oleole39 oleole39 changed the title Ole fix French translation + 2 original strings modifications Apr 22, 2020
@Kamuno Kamuno self-requested a review April 23, 2020 13:49
@petermayer petermayer self-assigned this May 7, 2020
@oleole39
Copy link
Author

oleole39 commented Jun 8, 2021

Hi @Kamuno, any hope for a merge soon?

@eliovir
Copy link
Contributor

eliovir commented Mar 6, 2024

I'd like to have Shopping List in French an I see there is already a PR for French translation.

Hi @coderPaddyS, @udenr, @jahway603 , can you review it?

@oleole39
Copy link
Author

Hello,
Is there still plan for reviewing/merging this ?

@coderPaddyS
Copy link
Contributor

We'll soon add language translation support via weblate, as e.g. added to the qr-scanner

@coderPaddyS coderPaddyS merged commit fe2fa5b into SecUSo:master Jan 8, 2025
@oleole39
Copy link
Author

oleole39 commented Jan 8, 2025

Hello @eliovir,
French translations now seems included in master branch (though not released yet) but can be improved there (new strings?) if you feel like it: https://hosted.weblate.org/projects/pfa/shopping-list/shopping-list-android-app

@eliovir
Copy link
Contributor

eliovir commented Jan 10, 2025

Hello @oleole39,
Thanks for your remark. I've reviewed the translations and corrected the warnings (typography mainly).
I hope an updated version will appear soon in F-droid ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants