Fix "Create Case" Error #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a case, we 1) make a call to create a case, 2) $router.replace to update the url with the new case ID, 3) use the route params to load the case. Step 2 is async so step 3 used the old ID param of `create`. Adding an await on step 2 ensures that the new route params are used in step 3 and we don't attempt to retrieve a case with a bad ID.
jertel
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a case, we 1) make a call to create a case, 2) $router.replace to update the url with the new case ID, 3) use the route params to load the case. Step 2 is async so step 3 used the old ID param of
create. Adding an await on step 2 ensures that the new route params are used in step 3 and we don't attempt to retrieve a case with a bad ID.In Vue 2, $router.replace was effectively synchronous as it updated the $route without the need of await.