Prevent Second Popup When Disabling Detection #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disabling a detection, we want to offer a popup to the user asking "Do you also want to acknowledge all alerts for this detection?" This popup is controlled by the Detection Panel and is desired. However if the user clicks Yes, the panel calls out to the alerts page to do the actual acknowledging. At the page level, a new optional parameter was added to the ack function to help with a soon-to-be-implemented feature where every event can be escalated and this too will have a dialog. The detection panel was failing to provide the new optional parameter that would hide this second page-level popup and thus 2 confirmation popups were being displayed. Having the detection panel pass `true` for this optional parameter prevents the second popup and provides the user with a cleaner experience as we originally intended. Updated test.
jertel
approved these changes
Jan 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling a detection, we want to offer a popup to the user asking "Do you also want to acknowledge all alerts for this detection?" This popup is controlled by the Detection Panel and is desired. However if the user clicks Yes, the panel calls out to the alerts page to do the actual acknowledging. At the page level, a new optional parameter was added to the ack function to help with a soon-to-be-implemented feature where every event can be escalated and this too will have a dialog. The detection panel was failing to provide the new optional parameter that would hide this second page-level popup and thus 2 confirmation popups were being displayed. Having the detection panel pass
truefor this optional parameter prevents the second popup and provides the user with a cleaner experience as we originally intended.Updated test.