Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-cli to 3.28.5, make compatible with Ember 4.x #2

Merged
merged 8 commits into from
Aug 1, 2022

Conversation

Gaurav0
Copy link

@Gaurav0 Gaurav0 commented Jul 25, 2022

Upstream PR: johno#42

gustavolbs
gustavolbs previously approved these changes Jul 25, 2022
MayconnW
MayconnW previously approved these changes Jul 27, 2022
parserOptions: {
ecmaVersion: 2017,
sourceType: 'module'
ecmaVersion: 2018,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Nice catch!

@Gaurav0 Gaurav0 changed the base branch from master to scf-master August 1, 2022 18:49
@Gaurav0 Gaurav0 dismissed stale reviews from MayconnW and gustavolbs August 1, 2022 18:49

The base branch was changed.

@AndrewHYi
Copy link

🚀

@AndrewHYi AndrewHYi merged commit ca41596 into scf-master Aug 1, 2022
@AndrewHYi AndrewHYi deleted the update_4x branch August 1, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants