Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify makeAnimation() to calculate vmin and vmax value globally for the cube #25

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Modify makeAnimation() to calculate vmin and vmax value globally for the cube #25

merged 3 commits into from
Jun 4, 2024

Conversation

firasalchalabi
Copy link
Collaborator

@firasalchalabi firasalchalabi commented Jun 4, 2024 •
edited
Loading

  • Added a function to calculate vmin, vmax values based on pclip
  • Calculate vmin and vmax globally for the cube in makeAnimation
  • Using the helper function to calculate vmin, vmax instead of calculating directly

@firasalchalabi firasalchalabi self-assigned this Jun 4, 2024
AtilaSaraiva
AtilaSaraiva approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@AtilaSaraiva AtilaSaraiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I wanted, thx!

@AtilaSaraiva AtilaSaraiva merged commit f1ffddf into SeismicJulia:main Jun 4, 2024
4 checks passed
@AtilaSaraiva AtilaSaraiva mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtilaSaraiva AtilaSaraiva AtilaSaraiva approved these changes

Assignees

@firasalchalabi firasalchalabi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firasalchalabi @AtilaSaraiva