Skip to content

Commit

Permalink
Fix json encoding in ChromePHPHandler, fixes #160
Browse files Browse the repository at this point in the history
  • Loading branch information
@Seldaek
Seldaek committed Feb 11, 2013
1 parent 20c831e commit 9dc4ffc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Monolog/Handler/ChromePHPHandler.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ protected function send()
self::$initialized = true;
}

$this->sendHeader(self::HEADER_NAME, base64_encode(utf8_encode(json_encode(self::$json))));
$json = @json_encode(self::$json);
$this->sendHeader(self::HEADER_NAME, base64_encode(utf8_encode($json)));
}

/**
Expand Down

4 comments on commit 9dc4ffc

@ahundiak
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just downloaded a fresh copy of S2 RC2. The fix is not in there. Tried running composer update as well. No luck. Seems strange that it is taking composer so long to pick up the commit. Wonder if the zipball got regenerated.

@stof
Copy link
Contributor

@stof stof commented on 9dc4ffc Feb 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahundiak Composer can pick the latest commit. But the Symfony RC2 archive uses the Monolog tag, not the latest commit of the dev branch

@Seldaek
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a new tag, so updating again should fix it for you.

@ahundiak
Copy link

@ahundiak ahundiak commented on 9dc4ffc Feb 13, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.