-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(envoy): upgrade models in experiment #5874
fix(envoy): upgrade models in experiment #5874
Conversation
2456147
to
3fea100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm;
I haven't done a smoke test in kind but everything looks ok code-wise. For some reason I thought this would require a larger change.
I have done a smoke test in kind and added the steps for release testing. |
What this PR does / why we need it:
This change addresses 2 issues related to
Experiments
:Default
route pointing to this model, the old versions of the model are not unloaded. This is incorrect behaviour.The changes are respectively:
UnloadEnvoyRequested
) before unloading a model (UnloadRequested
).Which issue(s) this PR fixes:
Fixes # INFRA-1001 (internal)
Special notes for your reviewer: