Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): cli as k8s deployment for debugging #6090

Merged
merged 42 commits into from
Nov 27, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Nov 22, 2024

What this PR does / why we need it:

This PR creates a docker image seldonio/seldon-cli with Seldon CLI prepackaged in it. Users can then deploy this image in Kubernetes alongside Core 2 installation in the same namespace.

This PR also factors out kafka config code into a top level component so that it can be used by the cli and especially in a Kubernetes deployment where it can have access to seldon-kafka ConfigMap for consumer config.

We have disabled also Seldon CLI control plane operations (e.g. load and unload) by default as they can cause inconsistencies in Kubernetes installation. They can be re-enabled with the flag --force.

Docs have been also adjust and perhaps it would be a good entrypoint to review the changes of this PR. Link to rendered docs here.

Which issue(s) this PR fixes:

Fixes Infra-1269 (internal)

Special notes for your reviewer:

  • Unit tests have been added for this change.
  • CI changes added to include tests and builds of the new top level component.

@sakoush sakoush requested a review from lc525 as a code owner November 22, 2024 16:39
@sakoush sakoush added the v2 label Nov 22, 2024
@sakoush sakoush marked this pull request as draft November 22, 2024 16:39
@sakoush sakoush removed the request for review from lc525 November 22, 2024 16:40
@sakoush sakoush marked this pull request as ready for review November 26, 2024 16:27
Copy link

@driev driev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - left a few small comments.

components/kafka/Makefile Show resolved Hide resolved
docs-gb/cli/README.md Show resolved Hide resolved
operator/Dockerfile.cli Show resolved Hide resolved
operator/config/cli/seldon-cli-remote.sh Outdated Show resolved Hide resolved
@sakoush sakoush merged commit 30b0340 into SeldonIO:v2 Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants