-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update] installation draft #6131
Conversation
Rakavitha Kodhandapani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Regarding Production install, I think it is a good idea to provide context on the different types of helm charts that we provide, as well as the link to those helm charts (either the Core 2 repo charts in k8s/helm-charts or the helm-charts repo itself). Similar to how we used to have this here: https://docs.seldon.ai/seldon-core-2/getting-started/kubernetes-installation/helm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments on the current production install for Core 2. I think this is fine as a first cut, I suggest the following topics as follow up PRs:
- How to configure Core 2 installation via helm and what are the different settings that can be changed that are relevant to note. This is important in cases of resource allocations, tags, number of pods etc, mTLS etc.
- How to manage upgrade via helm. Upgrading Core 2 is perhaps a topic that needs more attention to document behaviour and provide options for a smooth upgrade.
incorporate review comments from Sherif
incorporate Sherif's comments
incorporate Sherif's comments.
incorporate Sherif's comments
incorporate Sherif's comments
Hi @paulb-seldon can we add these topics to the new IA so that we dont miss these suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a first pass. Really big improvement, let's merge!
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: