Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] installation draft #6131

Merged
merged 98 commits into from
Feb 12, 2025
Merged

[update] installation draft #6131

merged 98 commits into from
Feb 12, 2025

Conversation

Rajakavitha1
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ paulb-seldon
✅ Rajakavitha1
❌ Rakavitha Kodhandapani


Rakavitha Kodhandapani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Rajakavitha1 Rajakavitha1 marked this pull request as ready for review December 14, 2024 02:57
@Rajakavitha1 Rajakavitha1 marked this pull request as draft December 14, 2024 03:02
@paulb-seldon
Copy link
Contributor

Regarding Production install, I think it is a good idea to provide context on the different types of helm charts that we provide, as well as the link to those helm charts (either the Core 2 repo charts in k8s/helm-charts or the helm-charts repo itself). Similar to how we used to have this here: https://docs.seldon.ai/seldon-core-2/getting-started/kubernetes-installation/helm

@sakoush sakoush added the v2 label Feb 7, 2025
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments on the current production install for Core 2. I think this is fine as a first cut, I suggest the following topics as follow up PRs:

  • How to configure Core 2 installation via helm and what are the different settings that can be changed that are relevant to note. This is important in cases of resource allocations, tags, number of pods etc, mTLS etc.
  • How to manage upgrade via helm. Upgrading Core 2 is perhaps a topic that needs more attention to document behaviour and provide options for a smooth upgrade.

incorporate review comments from Sherif
incorporate Sherif's comments
incorporate Sherif's comments.
incorporate Sherif's comments
incorporate Sherif's comments
@Rajakavitha1 Rajakavitha1 requested a review from sakoush February 10, 2025 06:42
@Rajakavitha1
Copy link
Contributor Author

I left some comments on the current production install for Core 2. I think this is fine as a first cut, I suggest the following topics as follow up PRs:

  • How to configure Core 2 installation via helm and what are the different settings that can be changed that are relevant to note. This is important in cases of resource allocations, tags, number of pods etc, mTLS etc.
  • How to manage upgrade via helm. Upgrading Core 2 is perhaps a topic that needs more attention to document behaviour and provide options for a smooth upgrade.

Hi @paulb-seldon can we add these topics to the new IA so that we dont miss these suggestions.

Copy link
Contributor

@paulb-seldon paulb-seldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a first pass. Really big improvement, let's merge!

@Rajakavitha1 Rajakavitha1 merged commit 7482196 into v2 Feb 12, 2025
4 of 6 checks passed
@Rajakavitha1 Rajakavitha1 deleted the core2-install-rajie branch February 12, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants