Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix port to 9004 in seldon cli deps #6164

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Dec 17, 2024

What this PR does / why we need it:

In some cases the envars required for the example cli pod deployment are not set up properly. Until we investigate, we pin it now to 9004 which has not changed recently.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sakoush sakoush requested a review from lc525 as a code owner December 17, 2024 15:04
@sakoush sakoush added the v2 label Dec 17, 2024
@sakoush sakoush requested review from cherrymu and removed request for lc525 December 17, 2024 15:06
Copy link
Member

@cherrymu cherrymu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sakoush sakoush merged commit 8e40931 into SeldonIO:v2 Dec 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants