Update Authlib and pass verify flag downstream #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
reviewed
Jul 26, 2022
|
Worth to link that it addresses #45 |
agrski
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
I haven't actually tested this (happy to do so if you'd prefer @adriangonz), but the content of the changes looks good 👍
added 7 commits
November 1, 2022 11:51
adriangonz
force-pushed
the
verify-false
branch
from
56b8c90 to
1c46a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
verify=Falsedownstream if presentwebbrowserpackage to open up browser automatically when using theauth_codeflowAuthMethodenum in theseldon_deploy_sdk.authpackage to avoid using hardcoded strings