WIP: Control flow fork #198
Conversation
| @@ -25,6 +25,8 @@ export default class Command { | |||
| @observable target = ""; | |||
| @observable value = ""; | |||
| @observable isBreakpoint = false; | |||
| @observable left = {}; | |||
There was a problem hiding this comment.
Don't turn Command into an Either,
Have a Node class that has right left and command.
This information changes on a rapid basis, and is only accurate at the time of the run, which is recalculated anyway.
Keep the tree in the scope of the test run alone.
| @@ -112,6 +114,36 @@ function doCommands(request, sender, sendResponse) { | |||
| } | |||
| } | |||
|
|
|||
| function isConditinal(commandName) { | |||
There was a problem hiding this comment.
This code is unnecessary, just add Selenium.prototype.doConditional, make it something like,
return !!eval(conditional).
This will give you more control, we just need a new class of commands, I believe.
Currently we have 2:
- Content script commands
- Ext commands
We also have type which is in the middle, because it's both, it has to wait like a content command, but it needs the elevated background script.
IMO just create an isFlowCommand (like isExtCommand), and execute them in that place (similarly to how I execute type, after the waiting).
There was a problem hiding this comment.
This code is being reconsidered while I'm working on sandboxing.
|
We also need to understand how to handle invalid flow, we need to parse it, and error immediately when the user attempts to play.
-- this has got to fail immediately |
…ty for validation.
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| export default class SuiteValidator{ |
There was a problem hiding this comment.
Suite is a container of test cases,
A test case has a list of commands to run.
So in practice we validate a Test Case and not a Suite.
Let's rename this to TestCaseValidator
I took @corevo 's branch as a starting point for a new way to control over test execution in order to provide control flow operators like
ifandwhileand make they inclusion as painless as possible. General plan is to completePlaybackTreein a way where every new control flow command will have correctleftandrightbranches pointing to the next correct command to execute. I'm also thinking about separatingleft,rightand every possible future property related to the control flow into separate data structure bound toCommand.Basic concept of how
PlaybackTreeprocesses commands is displayed in here:With execution implemented I'll need to figure out how to properly
evalconditionals in order to use stored variables as a context.Added
repeatIf,do,elseIfOnly
times,continue,breakleftAdded test case validator class which is responsible for keeping block integrity and capable of pointing to the errors in the suite. Also added specs for it.
I'll update this description on the go.