Harmonize resource loading spinner #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SemanticResultFormats were using 2 different spinners,
srf-loading-dots, used for instance in datatables, and a more convoluted (or unattractive) spinnersrf-spinneras in the picture.the present commits unifies the 2 different spinners using always the following
The old spinner tried to take into account the container size, but fails to do so in many cases since the container size isn't fixed in all cases and is determined by the rendered widget, so where this feature is envisaged this commit could be followed by a further enhancement, to ensure that all containers have fixed width, and to use the standard
mw-rcfilters-spinner(see picture below) in these cases. (or as a replacement of the spinner now used).