Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding filename in Content-Disposition header #1596

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

hashtagnulla
Copy link
Contributor

Previously, when a user tried to upload a file that's filename included non-ascii characters, the frontend couldn't build the header and the process was interrupted. Now it's fixed :)

@hashtagnulla hashtagnulla added bug Something isn't working frontend labels Feb 14, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nagy Viktor seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e194979) 92.47% compared to head (6b1f420) 92.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1596   +/-   ##
========================================
  Coverage    92.47%   92.47%           
========================================
  Files          253      253           
  Lines         7149     7149           
  Branches      1937     1937           
========================================
  Hits          6611     6611           
  Misses         538      538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sensenet bot commented Feb 14, 2024

Site name Url Last deploy
sn-react-component-docs-dev https://65cd27e3017c590c571e17ec--sn-react-component-docs-dev.netlify.app Wed Feb 14 2024 - 20:51:47 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://65cd27df7769f221c30d15c0--sn-app-dev.netlify.app Wed Feb 14 2024 - 20:51:46 GMT+0000 (Coordinated Universal Time)

@tusmester tusmester merged commit 5d82b93 into develop Feb 19, 2024
7 checks passed
@tusmester tusmester deleted the fix/upload-file branch February 19, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants