-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove assumption user ID is 1000 #553
base: master
Are you sure you want to change the base?
Conversation
2fc86ca
to
0b29eb3
Compare
Err - 100 ? Should that be 1000 ? I think it's only the commit message above. I couldn't find any 100 in the changed files (but I do have ancient eyeballs). |
I was trying to show what it does on a non-default install. Clarified. |
0b29eb3
to
157cebe
Compare
993e156
to
3fa64f7
Compare
8bdfdb8
to
c60b752
Compare
This container includes cron and should be easier to use than the current duck.sh script. After a test period this should completely replace the current ./duck/duck.sh script. Currently uses my fork of linuxserver/docker-duckdns to include some needed pull-requests that are pending. Depends on SensorsIot#553 to generate .env with IOTSTACK_UID and IOTSTACK_GID Mkdocs and material versions updated to fix layout bug.
9074543
to
27fb6c0
Compare
This container includes cron and should be easier to use than the current duck.sh script. After a test period this should completely replace the current ./duck/duck.sh script. Currently uses my fork of linuxserver/docker-duckdns to include some needed pull-requests that are pending upstream pull-requests. Depends on SensorsIot#553 to generate .env with IOTSTACK_UID and IOTSTACK_GID Mkdocs and material versions updated to fix layout bug.
This container includes cron and should be easier to use than the current duck.sh script. After a test period this should completely replace the current ./duck/duck.sh script. Currently uses my fork of linuxserver/docker-duckdns to include some needed pull-requests that are pending upstream pull-requests. Depends on SensorsIot#553 to generate .env with IOTSTACK_UID and IOTSTACK_GID Mkdocs and material versions updated to fix layout bug.
Alternate suggestion (NOT RECOMMENDED)I think it's better to change this so a Templates would still use the syntax allowing .env-use: - PUID=${IOTSTACK_UID:?replace with your actual UID} buildstack_menu.py would identify template environment variable values matching - PUID=1000 Resoning
Drawbacks
|
On menu.sh start, store current UID and GID to .env, if they are missing. Use these to run services that use a customized user.
27fb6c0
to
0c6d564
Compare
DO NOT MERGE YET
On menu.sh start, store current UID and GID to
.env
, if they are missing.Use these to run services that support a custom user setting.
Lines added to
.env
by menu.sh are e.g.:And in templates and services:
When dropping the ID=1000 assumption, there is only one chance to get this right:
Other small changes:
Resolves #542, Fixes #183