Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFI Prekernel (5/N): EFIPrekernel: Add basic skeleton #24995

Merged
merged 7 commits into from
Dec 1, 2024

Conversation

spholz
Copy link
Member

@spholz spholz commented Sep 6, 2024

This skeleton is already bootable on all our supported architectures.

This PR depends on #24984 and #24985, therefore draft.

@spholz spholz changed the title EFI Prekernel (5/N): EFIPrekenel: Add basic skeleton EFI Prekernel (5/N): EFIPrekernel: Add basic skeleton Sep 6, 2024
Copy link

stale bot commented Sep 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Sep 28, 2024
@spholz spholz removed the stale label Sep 29, 2024
Copy link

stale bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Nov 5, 2024
@spholz spholz removed the stale label Nov 6, 2024
@timschumi timschumi self-requested a review November 13, 2024 08:13
@spholz spholz marked this pull request as ready for review November 15, 2024 14:23
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Nov 15, 2024
Copy link
Member

@timschumi timschumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit factoring is somewhat unfortunate, but there is no real way to fix it and everything else looks reasonable as well. I'll try and find a quiet moment to give it a spin.

@timschumi timschumi merged commit faeb9ff into SerenityOS:master Dec 1, 2024
15 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 1, 2024
spholz added a commit to spholz/serenity that referenced this pull request Dec 1, 2024
This target was removed in 175f9dc, but the dependency on it wasn't
removed from faeb9ff before PR SerenityOS#24995 was merged.
This should make everything build again.
@spholz spholz deleted the efi-prekernel-5 branch December 1, 2024 12:46
spholz added a commit that referenced this pull request Dec 1, 2024
This target was removed in 175f9dc, but the dependency on it wasn't
removed from faeb9ff before PR #24995 was merged.
This should make everything build again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants