-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser: Port browser to GML compilation #25399
base: master
Are you sure you want to change the base?
Conversation
Oh yes, one more thing to add that felt kinda wrong. The GML compiler works in a way that prevents forward declaration in widget headers. I wonder if there's anything we can do about that and if that's intended. Widget headers become quite huge because of that. |
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
309d010
to
1355efc
Compare
Browser: Port StorageWidget to GML compilation
1355efc
to
f2b5c4c
Compare
Looks like this needs rebasing now, sorry! As for the questions, iirc @kleinesfilmroellchen wrote the GML compiler. Film, do you know what we do about forward declarations? Just not worry about it? |
This PR contributes to #20518
It ports Browser. I'm open for suggestions regarding refactoring of BrowserTabWidget. It's quite puzzling. I'm not sure the way I did it is the best. Please review carefully.
Additionally, I got confused with all the different initialization functions like
try_create
,initialize
, andsetup
. Do we preferinitialize
oversetup
now?