Everywhere: Rename DeprecatedFlyString to FlyByteString
#25513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninadsachania
force-pushed
the
everywhere-rename-deprecatedflystring-to-flybytestring
branch
from
005f370 to
f5875f7
Compare
github-actions
bot
added
the
👀 pr-needs-review
DanShaders
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Seems reasonable, especially since #22926 removed the main reason for deprecation--the null state--over nine months ago. (I didn't look too closely at mechanical changes though)
| @@ -7,7 +7,7 @@ set(AK_SOURCES | |||
| ConstrainedStream.cpp | |||
| CountingStream.cpp | |||
| DOSPackedTime.cpp | |||
| DeprecatedFlyString.cpp | |||
| FlyByteString.cpp | |||
There was a problem hiding this comment.
This should be in alphabetic order.
| @@ -56,8 +56,8 @@ class FlyString { | |||
| [[nodiscard]] static size_t number_of_fly_strings(); | |||
|
|
|||
| // FIXME: Remove these once all code has been ported to FlyString | |||
| [[nodiscard]] DeprecatedFlyString to_deprecated_fly_string() const; | |||
| static ErrorOr<FlyString> from_deprecated_fly_string(DeprecatedFlyString const&); | |||
| [[nodiscard]] FlyByteString to_deprecated_fly_string() const; | |||
There was a problem hiding this comment.
{to,from}_fly_byte_string, maybe?
| @@ -32,7 +32,7 @@ class ConstrainedStream; | |||
| template<typename T> | |||
| class Coroutine; | |||
| class CountingStream; | |||
| class DeprecatedFlyString; | |||
| class FlyByteString; | |||
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions! |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #25492.