Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues for windows #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dcallies
Copy link

@Dcallies Dcallies commented Jun 9, 2024

Hey, I was playing around with your library on my windows machine, and noticed the following:

  1. I get a decode error when using pip to install locally from the long_description trying to read the README. Switching to a simple encoding fixes it and allows local installs on windows, but probably breaks other things (guessing it's the emoji characters)
    1. I can try reading it first unencoded, and only falling back if it fails
  2. This one is weird - I assume a previous version of requests auto-set JSON content type or the Vestaboard API didn't enforce it, but it appears that it is enforcing now, or at least fails to post if JSON is not explicitly set.

Let me know what you want me to do #2, I also didn't spend any time looking for other sites that potentially needed the content type set explicitly.

@Dcallies
Copy link
Author

Dcallies commented Jun 9, 2024

Reading some more, it might be the difference between json= and data= on requests - See https://requests.readthedocs.io/en/latest/user/quickstart/#more-complicated-post-requests "Please note that the above code will NOT add the Content-Type header"

@ShaneSutro
Copy link
Owner

Hi @Dcallies!
Thanks for the PR, I'll review and get this merged! Looks good as far as I can tell, I've got something to fix on my deployment pipeline it looks like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants