Fix input prompt not having whitespace #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fthycl
commented
Jun 1, 2024
| @@ -134,6 +134,14 @@ function runner.chain_commands(task_name, commands, module_config, addition_args | |||
| return | |||
| end | |||
|
|
|||
| if vim.fn.executable(command.cmd) == 0 then | |||
There was a problem hiding this comment.
Should we also check if command.cmd == nil here?
There was a problem hiding this comment.
Is it possible to have a nil here?..
There was a problem hiding this comment.
I hit that case while playing with the code, but it could be some temporary bug I introduced myself. I think this would only be possible if a module failed to define its command.
Shatur
requested changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
set_module_param, this PR changes the prompt fromSet "cmd" for module "cmake"cmake(no space, hard to read)to
Set "cmd" for module "cmake": cmake.It also returns early if the current
cmdis not executable to avoid unnecessarily long error messages printed by plenary.job.