fix review comments

Shelf-nu · Jan 23, 2025 · af4919d · af4919d
1 parent aa998d7
commit af4919d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/app/emails/email.worker.server.ts b/app/emails/email.worker.server.ts
@@ -4,10 +4,14 @@ import type { EmailPayloadType } from "./types";
 import { SMTP_FROM } from "../utils/env";
 import { ShelfError } from "../utils/error";
 
+// every node will execute 5 jobs(teamSize) every 3 minutes(newJobCheckIntervalSeconds),
+// increase teamSize if you need better concurrency
+// but keep email provider rate limiting and a potential n/w throughput load on postgress in mind
+// teamSize of 20-25 is a good limit if we need to scale email throughput in the future
 export const registerEmailWorkers = async () => {
   await scheduler.work<EmailPayloadType>(
     QueueNames.emailQueue,
-    { newJobCheckIntervalSeconds: 60 * 3, teamSize: 2 },
+    { newJobCheckIntervalSeconds: 60 * 3, teamSize: 5 },
     async (job) => {
       await triggerEmail(job.data);
     }

diff --git a/app/modules/booking/email-helpers.ts b/app/modules/booking/email-helpers.ts
@@ -4,7 +4,6 @@ import type { BookingForEmail } from "~/emails/types";
 import { getDateTimeFormatFromHints } from "~/utils/client-hints";
 import { getTimeRemainingMessage } from "~/utils/date-fns";
 import { SERVER_URL } from "~/utils/env";
-import { ShelfError } from "~/utils/error";
 import type { ClientHint } from "./types";
 
 /**

diff --git a/app/modules/booking/service.server.ts b/app/modules/booking/service.server.ts
@@ -1347,7 +1347,6 @@ export async function bulkDeleteBookings({
       }),
     }));
 
-    // Send emails with rate limiting
     return emailConfigs.map(sendEmail);
   } catch (cause) {
     const message =