Service endpoint error handling and automated tests #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjfreund
requested review from
lgarofalo,
richardxia,
schroerbrian and
waynekoepcke
as code owners
lgarofalo
reviewed
Nov 21, 2024
| @@ -77,6 +80,8 @@ func writeJson(w http.ResponseWriter, object interface{}) { | |||
| output, err := json.Marshal(object) | |||
| if err != nil { | |||
| fmt.Println("error:", err) | |||
There was a problem hiding this comment.
We probably should write this as log.Printf("%v", err)
lgarofalo
reviewed
Nov 21, 2024
| } | ||
| dbService := m.DbClient.GetServiceById(serviceId) | ||
| dbService, err := m.DbClient.GetServiceById(serviceId) |
There was a problem hiding this comment.
We should check this err right here
lgarofalo
reviewed
Nov 21, 2024
| var service Service | ||
| err := row.Scan(&service.Id, &service.CreatedAt, &service.UpdatedAt, &service.Name, &service.LongDescription, &service.Eligibility, &service.RequiredDocuments, &service.Fee, &service.ApplicationProcess, &service.ResourceId, &service.VerifiedAt, &service.Email, &service.Status, &service.Certified, &service.ProgramId, &service.InterpretationServices, &service.Url, &service.WaitTime, &service.ContactId, &service.FundingId, &service.AlternateName, &service.CertifiedAt, &service.Featured, &service.SourceAttribution, &service.InternalNote, &service.ShortDescription) | ||
| if err != nil { |
lgarofalo
reviewed
Nov 21, 2024
| @@ -34,7 +34,7 @@ func (m *Manager) Submit(w http.ResponseWriter, r *http.Request) { | |||
| var service *db.Service | |||
| switch changeRequest.Type { | |||
| case "ServiceChangeRequest": | |||
| service = m.DbClient.GetServiceById(changeRequest.ObjectID) | |||
| service, err = m.DbClient.GetServiceById(changeRequest.ObjectID) | |||
There was a problem hiding this comment.
Should check this err right here
lgarofalo
reviewed
Nov 21, 2024
| @@ -44,6 +44,13 @@ func TestGetServiceByID(t *testing.T) { | |||
| assert.Equal(t, serviceResponse.Service.Id, serviceId, "Service Id is a match") | |||
| } | |||
|
|
|||
| func TestGetServiceByIDWithInvalidID(t *testing.T) { | |||
There was a problem hiding this comment.
cool, any issues using the test?
lgarofalo
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.