reorder shipengine exception to preserve preexisting argument position

ShipEngine · Jun 28, 2024 · 55261e5 · 55261e5
1 parent 05bbfa7
commit 55261e5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/ShipEngine/Models/ShipEngineException.cs b/ShipEngine/Models/ShipEngineException.cs
@@ -13,8 +13,8 @@ public class ShipEngineException(
         ErrorSource errorSource = ErrorSource.Shipengine,
         ErrorType errorType = ErrorType.System,
         ErrorCode errorCode = ErrorCode.Unspecified,
-        HttpResponseMessage? responseMessage = null,
-        string? requestID = null)
+        string? requestID = null,
+        HttpResponseMessage? responseMessage = null)
         : Exception(message)
     {
         /// <summary>

diff --git a/ShipEngine/PublicAPI.Shipped.txt b/ShipEngine/PublicAPI.Shipped.txt
@@ -1202,7 +1202,7 @@ ShipEngineSDK.ShipEngineException.ErrorType.set -> void
 ShipEngineSDK.ShipEngineException.RequestId.get -> string?
 ShipEngineSDK.ShipEngineException.ResponseMessage.get -> System.Net.Http.HttpResponseMessage?
 ShipEngineSDK.ShipEngineException.ResponseMessage.set -> void
-ShipEngineSDK.ShipEngineException.ShipEngineException(string! message, ShipEngineSDK.ErrorSource errorSource = ShipEngineSDK.ErrorSource.Shipengine, ShipEngineSDK.ErrorType errorType = ShipEngineSDK.ErrorType.System, ShipEngineSDK.ErrorCode errorCode = ShipEngineSDK.ErrorCode.Unspecified, System.Net.Http.HttpResponseMessage? responseMessage = null, string? requestID = null) -> void
+ShipEngineSDK.ShipEngineException.ShipEngineException(string! message, ShipEngineSDK.ErrorSource errorSource = ShipEngineSDK.ErrorSource.Shipengine, ShipEngineSDK.ErrorType errorType = ShipEngineSDK.ErrorType.System, ShipEngineSDK.ErrorCode errorCode = ShipEngineSDK.ErrorCode.Unspecified, string? requestID = null, System.Net.Http.HttpResponseMessage? responseMessage = null) -> void
 ShipEngineSDK.ShipEngineExtensions
 ShipEngineSDK.ShipEngineMock
 ShipEngineSDK.ShipEngineMock.ShipEngineMock() -> void

diff --git a/ShipEngine/ShipEngineClient.cs b/ShipEngine/ShipEngineClient.cs
@@ -108,8 +108,8 @@ private async Task<T> DeserializedResultOrThrow<T>(HttpResponseMessage response)
                         error.ErrorSource,
                         error.ErrorType,
                         error.ErrorCode,
-                        response,
-                        deserializedError.RequestId
+                        deserializedError.RequestId,
+                        response
                     );
                 }
 
@@ -210,8 +210,8 @@ private async Task WaitAndRetry(HttpResponseMessage? response, Config config, Sh
                     ErrorSource.Shipengine,
                     ErrorType.System,
                     ErrorCode.Timeout,
-                    ex.ResponseMessage,
-                    ex.RequestId
+                    ex.RequestId,
+                    ex.ResponseMessage
                 );
             }