Revert "Remove LegacyStart, LegacyEnd"

This reverts commit 08c4bd7.
ShootMe · Feb 26, 2025 · 936b773 · 936b773
1 parent 35de691
commit 936b773
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/HollowKnightComponent.cs b/HollowKnightComponent.cs
@@ -301,6 +301,19 @@ private SplitterAction CheckSplit(SplitName split, string nextScene, string scen
 
                 #region Start and End
 
+                case SplitName.LegacyStart:
+                    shouldSplit =
+                        (nextScene.Equals("Tutorial_01", StringComparison.OrdinalIgnoreCase)
+                            && mem.GameState() == GameState.ENTERING_LEVEL)
+                        || nextScene is "GG_Vengefly_V" or "GG_Boss_Door_Entrance" or "GG_Entrance_Cutscene";
+                    break;
+
+                case SplitName.LegacyEnd:
+                    shouldSplit =
+                        nextScene.StartsWith("Cinematic_Ending", StringComparison.OrdinalIgnoreCase)
+                        || nextScene == "GG_End_Sequence";
+                    break;
+
                 case SplitName.StartNewGame:
                     shouldSplit =
                         (nextScene.Equals("Tutorial_01", StringComparison.OrdinalIgnoreCase)

diff --git a/HollowKnightSplitSettings.cs b/HollowKnightSplitSettings.cs
@@ -59,13 +59,19 @@ private void picHandle_MouseDown(object sender, MouseEventArgs e) {
     }
     public enum SplitName {
 
+        [Description("[DEPRECATED] Start Run (Start)"), ToolTip("Splits when autosplitter version 3 would have automatically started runs")]
+        LegacyStart,
+
         [Description("Start New Game (Start)"), ToolTip("Splits when starting a new game, including Normal, Steel Soul, and Godseeker mode")]
         StartNewGame,
         [Description("Start Pantheon (Start)"), ToolTip("Splits when starting a Pantheon run")]
         StartPantheon,
         [Description("Rando Wake (Start)"), ToolTip("Splits when gaining control after waking up in Rando")]
         RandoWake,
 
+        [Description("[DEPRECATED] End Run (Ending)"), ToolTip("Splits when autosplitter version 3 would have automatically ended runs")]
+        LegacyEnd,
+
         [Description("Credits Roll (Ending)"), ToolTip("Splits on any credits rolling")]
         EndingSplit,
         [Description("The Hollow Knight (Ending)"), ToolTip("Splits on The Hollow Knight ending")]