Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated splits from @mayonnaisical #85

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AlexKnauth
Copy link
Contributor

@AlexKnauth AlexKnauth commented Dec 2, 2024

An updated version of slaurent22#27 to resolve merge conflicts.

  • Address review comments that have been made on Discord (Mostly done)
  • Add start trigger separator: add start trigger separator mayonnaisical/LiveSplit.HollowKnight#6
  • Transition excluding discontinuities (savestate, death, dreamgate)
  • door_dreamReturn is a discontinuity
  • Address TODOs left in the code
  • Test changes
    • Make sure 1028 Modded still works
    • Start New Game: normal, steel soul, godseeker
    • Start Pantheon: Pantheon 1-5, first-time cutscene, subsequent no-cutscene
    • Ending A-E and RadianceP: only on their respective endings
    • Menu splits: don't split on menu after condition was true but becomes false
    • Soul Sanctum Hallownest Seal
    • Stag Position Updated
    • City Toll Bench Room Transition
    • Transition excluding discontinuities: don't split on savestate, death, or dreamgate, including Godhome dreamgate-out
    • Has Shade Soul Transition: make sure it still works as expected in normal NMG play; idk how to do room dupes
      • with some delay in real time, though no difference in loadless time
    • Enter Troupe Master Grimm: don't split when Grimmchild isn't equipped
    • Pure Snail: split on full focus at full health
    • Test savestates in Monomon dream for Transition excluding savestate and Transition excluding discontinuities
  • Version and changelog update with credit to Mayo and Python
  • Build release dll last

@AlexKnauth AlexKnauth marked this pull request as ready for review December 4, 2024 07:01
@AlexKnauth AlexKnauth mentioned this pull request Jan 8, 2025
@AlexKnauth AlexKnauth force-pushed the mayo-2 branch 17 times, most recently from 2054623 to dc9e74f Compare January 11, 2025 06:35
@AlexKnauth AlexKnauth mentioned this pull request Jan 11, 2025
@AlexKnauth AlexKnauth force-pushed the mayo-2 branch 7 times, most recently from 6111d12 to 6f1f88a Compare January 13, 2025 23:00
@AlexKnauth AlexKnauth marked this pull request as draft January 14, 2025 05:38
@AlexKnauth
Copy link
Contributor Author

Converting this to a draft for now. I will need to do one last rebase and dll build after the smaller PRs are merged, before this can be ready.

@AlexKnauth AlexKnauth force-pushed the mayo-2 branch 3 times, most recently from 38cc356 to 6826bb3 Compare January 30, 2025 00:11
@AlexKnauth AlexKnauth force-pushed the mayo-2 branch 2 times, most recently from 0be6aac to 3072bb3 Compare February 13, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant