Centralize Ruby Version to .ruby-version
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-ma
force-pushed
the
centralize_ruby_version
branch
2 times, most recently
from
7777473 to
21c0f6f
Compare
The `.ruby-version` file is the ecosystem standard for defining a Ruby version. This PR adds the `.ruby-version` file, ensures a `required_ruby_version` is set, and removes all other references to Ruby in this repository, aligning it with the standard. > [!IMPORTANT] > Please verify the following before merging: Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant: - [ ] `.ruby-version` file is present with the correct Ruby version defined - [ ] A `required_ruby_version` in your gemspec is set - [ ] There is no Ruby version present in the `dev.yml` Ruby task (before: `- ruby: x.x.x`, after: `- ruby`) - [ ] There is no Ruby version/requirement referenced in the `Gemfile` (no lines with `ruby <some-version>`) - [ ] A `Gemfile.lock` is built with the defined Ruby version - [ ] The version of Rubocop installed is 1.61.0 or greater - [ ] There is no `TargetRubyVersion` defined in `rubocop.yml` (reads from `required_ruby_version` on Rubocop 1.61.0) - [ ] There is no Ruby argument present in `ruby/setup-ruby` Github Actions that do **not** run on a Ruby matrix (no lines with `ruby-version: “x.x”`) To establish consistency, the `required_ruby_version`is set to 2.7. If you think that another version is a better fit, please make the applicable changes. Please merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.
they should be alphabetized
#exists? on File is deprecated and removed default proxy address was changed to :ENV in a159594
jenshenny
force-pushed
the
centralize_ruby_version
branch
from
883e53c to
1b1e01d
Compare
SSLPoster was leaking changes in state to other tests
jenshenny
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.ruby-versionfile is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-versionfile, ensures arequired_ruby_versionis set, and removes all other references to Ruby in this repository, aligning it with the standard.Important
Please verify the following before merging:
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-versionfile is present with the correct Ruby version definedrequired_ruby_versionin your gemspec is setdev.ymlRuby task (before:- ruby: x.x.x, after:- ruby)Gemfile(no lines withruby <some-version>)Gemfile.lockis built with the defined Ruby versionTargetRubyVersiondefined inrubocop.yml(reads fromrequired_ruby_versionon Rubocop 1.61.0)ruby/setup-rubyGithub Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”)To establish consistency, the
required_ruby_versionis set to 2.7. If you think that another version is a better fit, please make the applicable changes.Please merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.