YAML compile cache: encoding aware symbols #398
Merged
+139
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: msgpack/msgpack-ruby#211
The default msgpack Symbol packer/unpacker is not encoding, aware which cause all non-ASCII symbols to be unpacked with
ASCII-8BIT
encoding akaBINARY
.So we define a custom packer that prefix the symbol name with
1
for UTF-8 symbols, and0
for the others (ASCII or binary).If
Encoding.default_internal
is set to something MessagePack doesn't support, we entirely disable the YAML cache.