Remove buffered io usage

lib/dalli.rb

@@ -70,7 +70,6 @@ def self.logger=(logger)
 require_relative 'dalli/ring'
 require_relative 'dalli/protocol'
 require_relative 'dalli/protocol/base'
-require_relative 'dalli/protocol/buffered_io'
 require_relative 'dalli/protocol/connection_manager'
 require_relative 'dalli/protocol/meta'
 require_relative 'dalli/protocol/response_buffer'

lib/dalli/protocol/connection_manager.rb

@@ -12,7 +12,6 @@ module Protocol
     # Manages the socket connection to the server, including ensuring liveness
     # and retries.
     ##
-    # rubocop:disable Metrics/ClassLength
     class ConnectionManager
       DEFAULTS = {
         # seconds between trying to contact a remote server
@@ -24,9 +23,7 @@ class ConnectionManager
         # amount of time to sleep between retries when a failure occurs
         socket_failure_delay: 0.1,
         # Set keepalive
-        keepalive: true,
-        # chunk size for buffered io
-        chunk_size: 1024 * 4
+        keepalive: true
       }.freeze
 
       attr_accessor :hostname, :port, :socket_type, :options
@@ -40,7 +37,6 @@ def initialize(hostname, port, socket_type, client_options)
         @request_in_progress = false
         @sock = nil
         @pid = nil
-        @buffered_io = nil
 
         reset_down_info
       end
@@ -57,7 +53,6 @@ def establish_connection
         Dalli.logger.debug { "Dalli::Server#connect #{name}" }
 
         @sock = memcached_socket
-        @buffered_io = BufferedIO.new(@sock, options[:chunk_size], options[:socket_timeout])
         @pid = PIDCache.pid
         @request_in_progress = false
       rescue SystemCallError, *TIMEOUT_ERRORS, EOFError, SocketError => e
@@ -123,7 +118,6 @@ def close
           nil
         end
         @sock = nil
-        @buffered_io = nil
         @pid = nil
         abort_request!
       end
@@ -276,5 +270,4 @@ def log_up_detected
       end
     end
   end
-  # rubocop:enable Metrics/ClassLength
 end

test/integration/test_network.rb

@@ -335,12 +335,4 @@
       dc.close
     end
   end
-
-  it 'handles reading data from a socket that is larger than the buffer chunk size' do
-    memcached_persistent do |dc|
-      dc.set('foo', 'b' * (Dalli::Protocol::BufferedIO::DEFAULT_CHUNK_SIZE + 100))
-
-      assert_equal 'b' * (Dalli::Protocol::BufferedIO::DEFAULT_CHUNK_SIZE + 100), dc.get('foo')
-    end
-  end
 end