Support for i18next v24
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [i18next](https://github.com/i18next/i18next) from 23.16.8 to 24.0.0. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v23.16.8...v24.0.0) --- updated-dependencies: - dependency-name: i18next dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
trishrempel
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Required changes to support i18next v24.
What approach did you choose and why?
The latest version of i18next [v24] makes the Intl API required in all cases. This PR changes the call from
i18next.translator.pluralResolver.shouldUseIntlApi(which was removed) to a straight check onIntlwhich matches the i18next implementation.What should reviewers focus on?
It seems like we require
Intlor a polyfill already, so this shouldn't qualify as a breaking change. Any consequences we might be missing?The impact of these changes
The Intl API is already required, but this enforces it more directly in this library. It is supported in all major browsers with polyfills available for supporting older browsers.
Testing
...
Checklist