Add mapping integrations for taxonomy shopify/2024-07 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chesterbot01
commented
Oct 4, 2024
•
chesterbot01
commented
- pull shopify/2024-07 from https://github.com/Shopify/product-taxonomy/releases/tag/v2024-07
- Add the new mapping folders to the data directory for shopify/2024-07
- Generate a full_names.yml for the shopify/2024-07 version
chesterbot01
force-pushed
the
update-directory-folder-to-include-deprecate-taxonomy
branch
from
ba85a31 to
c5a1abc
Compare
chesterbot01
force-pushed
the
update-directory-folder-to-include-deprecate-taxonomy
branch
3 times, most recently
from
5cf1907 to
8b5549e
Compare
… ; generate a full_names.yml for the shopify/2024-07 version
chesterbot01
force-pushed
the
update-directory-folder-to-include-deprecate-taxonomy
branch
from
8b5549e to
fbcf91e
Compare
jeanrick
approved these changes
Oct 5, 2024
app/commands/seed_local_command.rb
Outdated
| @@ -139,6 +139,8 @@ def mapping_rules_from(data) | |||
| next if integration_id.nil? | |||
|
|
|||
| raw_mappings = sys.parse_yaml(file) | |||
| next if raw_mappings["rules"].nil? | |||
There was a problem hiding this comment.
nit Would prefer if rules was always an array and we didn't have to do a nil check here
| --- | ||
| input_taxonomy: shopify/2024-07 | ||
| output_taxonomy: shopify/2024-10-unstable | ||
| rules: |
There was a problem hiding this comment.
Suggest empty list here so that we don't have to modify the system to allow nil
Suggested change
| rules: | |
| rules: [] |
Comment on lines
152
to
153
| next if !taxonomy_version.include?("shopify") || taxonomy_version.include?("shopify/2022-02") || | ||
| taxonomy_version.include?("shopify/2024-07") |
There was a problem hiding this comment.
Let's get a better test here
This will allow shopify/2024-07 to be used as the input/output version of any mapping, which is not what we want. For e.g. in the google/2021-09-21 mapping (from shopify) shopify/2024-07 is not a valid version.
Ok to do this in a follow up PR so we can unblock #356 and #229
There was a problem hiding this comment.
Good call, I've revised the test to consider taxonomy versions in mapping files as valid if:
- The source taxonomy version matches the latest Shopify taxonomy version, OR
- The source taxonomy version is included in the allowlist of Shopify legacy source taxonomies: ["shopify/2022-02", "shopify/2024-07"], AND the destination taxonomy version matches the latest Shopify taxonomy version.
elsom25
approved these changes
Oct 5, 2024
chesterbot01
force-pushed
the
update-directory-folder-to-include-deprecate-taxonomy
branch
from
0cf07f6 to
dcd3f1e
Compare
chesterbot01
force-pushed
the
update-directory-folder-to-include-deprecate-taxonomy
branch
from
dcd3f1e to
eede049
Compare
chesterbot01
deleted the
update-directory-folder-to-include-deprecate-taxonomy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.