Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VP] Adding watercraft protective gear category #448

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ornanatan
Copy link
Contributor

Adding watercraft protective gear category and subcategories related.

@ornanatan ornanatan self-assigned this Nov 18, 2024
@ornanatan ornanatan added 2025-01 taxonomy-tree-requests Suggestion to improve to the taxonomy tree labels Nov 18, 2024
- protective_gear_features
- target_gender
- id: vp-1-6-5-3
name: Watercraft Wet Suits & Dry Suitss
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a typo in Watercraft Wet Suits & Dry Suitss - the word Suits has an extra 's' at the end. The category name should be Watercraft Wet Suits & Dry Suits.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

- accessory_size
- color
- handwear_material
- motorcycle_glove_purpose
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motorcycle_glove_purpose attribute appears to be incorrectly included for the Watercraft Gloves category. This attribute is specific to motorcycle gear and should be removed from watercraft equipment. Consider using more appropriate attributes that reflect the intended use case for watercraft gloves.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this one maybe need an extended attribute?

Copy link
Member

@tylerrowsell tylerrowsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Graphite comments seem correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-01 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants