Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SG] Adding racing Kayaks and Canoes #458

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ornanatan
Copy link
Contributor

Add categories for racing Kayaks and Canoes in sporting goods.
Add skill level attribute as well

@ornanatan ornanatan added taxonomy-tree-requests Suggestion to improve to the taxonomy tree 2025-01 labels Nov 24, 2024
@ornanatan ornanatan self-assigned this Nov 24, 2024
Comment on lines 5778 to 5784
name: Racing Canoes
children: []
attributes:
- color
- material
- pattern
- recommended_skill_level
Copy link
Contributor

@ricardotejedorsanz ricardotejedorsanz Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this addition, but Racing Canoes can create potential overlaps with existing Marathon Canoes and Sprint Canoes. I suggest we create this as a parent to marathon and sprint canoes [PR waiting to be merged when aligned on mappings infrastructure].

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-01 shopify-mappings taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants